Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maven30xRuntime.finalizeMojoConfiguration is not processing configurations properly when using new formats provided by sisu #9

Open
cvgaviao opened this issue Sep 17, 2015 · 1 comment

Comments

@cvgaviao
Copy link
Contributor

Given that I have the following configuration set for an MojoExecution instance by an unit test:

    <configuration>
       <manifestScope>compile</manifestScope>
       <manifestScope>test</manifestScope>
     </configuration>

This format of configuration is allowed by recent version of eclipse sisu since maven 3.1 under some circunstances. see [1].
The method finalizeMojoConfiguration(MojoExecution mojoExecution) from Maven30xRuntime is not considering it, resulting in a different configuration than expected.

A project that reproduce the problem can be found here [2].

[1] - http://blog.sonatype.com/2011/03/configuring-plugin-goals-in-maven-3/#.VdU-P7M2xC1
[2] - https://bugs.eclipse.org/bugs/show_bug.cgi?id=475588

@cvgaviao
Copy link
Contributor Author

@ifedorenko,
I identified were the problem is, but couldn't figure out how to fix it.

  • First doubt: should we override finalizeMojoConfiguration method on Maven331Runtime class or modify the existent one at Maven30xRuntime?
  • Second doubt: the flow of the finalizeMojoConfiguration method is based on mojoDescriptor.getParameters(). The execution configuration items that was set on test (manifestScope) does not appears on mojoDescriptor, but they outer container(manifestScopes). should we evaluate the parameter type ( whether it is a list), then calculate the singular name and compare with the execution configuration provided before add it to the finalConfiguration?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant