Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing albumReplayGain dictionary entry causes runtime exception #240

Closed
GioF71 opened this issue Feb 27, 2024 · 4 comments
Closed

Missing albumReplayGain dictionary entry causes runtime exception #240

GioF71 opened this issue Feb 27, 2024 · 4 comments

Comments

@GioF71
Copy link
Contributor

GioF71 commented Feb 27, 2024

Hello, using the current master branch (at commit 979e6cc), if I change you chosen album_id with 249593867, I get an error with the albumReplayGain dictionary entry. Looks like sometimes the information isn't set of course.

Thank you for your attention

@GioF71 GioF71 changed the title Missing replaygain information (album_id = 249593867) Missing albumReplayGain dictionary entry on album_id 249593867 Feb 27, 2024
@GioF71 GioF71 changed the title Missing albumReplayGain dictionary entry on album_id 249593867 Missing albumReplayGain dictionary causes runtime exception Feb 27, 2024
@GioF71 GioF71 changed the title Missing albumReplayGain dictionary causes runtime exception Missing albumReplayGain dictionary entry causes runtime exception Feb 27, 2024
@tehkillerbee
Copy link
Collaborator

@GioF71 Interesting, nice catch. Looks like this issue only occurs for albums where only SONY360 audio mode is available.

I have made a quickfix but it would be nice to test if this issue also occurs with other audio modes. Have you found any such albums?

@GioF71
Copy link
Contributor Author

GioF71 commented Feb 27, 2024

Well actually that one is on my favorites list, but I didn't even notice that it was encoded that way.
I saw there are other two versions of "Facelift". I don't even remember that as a memorable album anyway, but I bought it back in the day, so, I am kind of attached to it.

Sorry, I do not fully understand what do you mean with

it would be nice to test if this issue also occurs with other audio modes

I was using pkce authentication and the subscription is currently hifi plus.
Maybe you as me to test the other versions of the same album? If so, sure, I will try tomorrow with the other two versions of the same album.

@tehkillerbee
Copy link
Collaborator

tehkillerbee commented Feb 27, 2024

The fields are missing for certain albums, eg if they use Sony360 audio mode. But I have changed how these fields are set, so this issue should not occur again.

EDIT: I have not pushed my local changes yet but they will be part of my next PR.

@tehkillerbee
Copy link
Collaborator

Fixed in #242

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants