Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ymodem.py initial packet composition error #9

Open
ApiumJacob opened this issue Nov 12, 2021 · 1 comment
Open

ymodem.py initial packet composition error #9

ApiumJacob opened this issue Nov 12, 2021 · 1 comment

Comments

@ApiumJacob
Copy link

If I send a simple file called "hello.txt" using a program that I know has a working y-modem send protocol to another program that I know has a working y-modem receive program data transfer looks like (blue = sender, green = receiver, ymodem-ul is the command to start the receiver):
image

The initial packet payload consists of the filename + 0x00 + filesize + 0x00 padding.

The ymodem.py program is not adding the file size to the initial packet which is causing my receiver to reject the packet:

image

I'm not sure if either programs that I know work are compliant to the standard and the files size may be optional.

The checksum of the initial packet from ymodem.py does seem to be being calculated correctly.
image

@ApiumJacob
Copy link
Author

I see that this issue is addressed in pull request #2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant