Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename vectorize.table "table" parameter #145

Open
ChuckHend opened this issue Oct 11, 2024 · 3 comments · May be fixed by #163
Open

rename vectorize.table "table" parameter #145

ChuckHend opened this issue Oct 11, 2024 · 3 comments · May be fixed by #163
Labels

Comments

@ChuckHend
Copy link
Member

SELECT vectorize.table(
    job_name    => 'product_search_hf',
    "table"     => 'products',
    primary_key => 'product_id',
    columns     => ARRAY['product_name', 'description'],
    transformer => 'sentence-transformers/all-MiniLM-L6-v2',
    schedule    => 'realtime'
);

Having "table" as parameter causes a lot of issues for users. If the double quotes are missing the call will fail because table is a reserved word. We should rename that perhaps to "table_name" or "relation", and change the datatype to regclass. Idea with changing to regclass is that we will get more meaningful data validation errors if the table name provided does not exist, and I think using regclass would also mean we could remove the "schema" parameter.

@ChuckHend ChuckHend added the enhancement New feature or request label Oct 11, 2024
Copy link

algora-pbc bot commented Oct 17, 2024

💎 $100 bounty • Tembo

Steps to solve:

  1. Start working: Comment /attempt #145 with your implementation plan
  2. Submit work: Create a pull request including /claim #145 in the PR body to claim the bounty
  3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

Thank you for contributing to tembo-io/pg_vectorize!

Add a bountyShare on socials

Attempt Started (GMT+0) Solution
🟢 @varshith257 Oct 17, 2024, 12:21:56 PM #163

@varshith257
Copy link

varshith257 commented Oct 17, 2024

/attempt #145

Algora profile Completed bounties Tech Active attempts Options
@varshith257 16 bounties from 8 projects
Go, Rust,
Scala & more
Cancel attempt

Copy link

algora-pbc bot commented Oct 19, 2024

💡 @varshith257 submitted a pull request that claims the bounty. You can visit your bounty board to reward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants