From 5ac568ade713aff47a6e0b5df72ef669988dd95b Mon Sep 17 00:00:00 2001
From: Ian Stanton <ian@coredb.io>
Date: Tue, 25 Jul 2023 06:37:37 -0500
Subject: [PATCH] Print failed extensions

---
 .github/workflows/trunk-install-test.yml |  2 +-
 images/trunk-test/trunk-install.sh       | 19 ++++++++++++-------
 2 files changed, 13 insertions(+), 8 deletions(-)

diff --git a/.github/workflows/trunk-install-test.yml b/.github/workflows/trunk-install-test.yml
index 9fc95b35..c56485b3 100644
--- a/.github/workflows/trunk-install-test.yml
+++ b/.github/workflows/trunk-install-test.yml
@@ -35,6 +35,6 @@ jobs:
           sleep 5
           curl https://registry.pgtrunk.io/extensions/all | jq -r ".[] | .name" > /tmp/extensions.txt
           trunk-install.sh | tee /tmp/output.txt
-          results.sh
+#          results.sh
 #          grep -q ERROR /tmp/output.txt
 #          if [ $? -eq 1 ] ; then exit 1 ; else echo nope ; fi
diff --git a/images/trunk-test/trunk-install.sh b/images/trunk-test/trunk-install.sh
index a0b27dc5..9249262f 100755
--- a/images/trunk-test/trunk-install.sh
+++ b/images/trunk-test/trunk-install.sh
@@ -1,17 +1,22 @@
 #!/bin/bash
-failures=0
+failure_count=0
+failed_extensions=()
 file='/tmp/extensions.txt'
 lines=$(cat $file)
 for line in $lines
 do
         trunk install $line
         psql -c "create extension \"$line\" cascade;"
-        if [ $? -eq 0 ]; then
-            echo "Command succeeded"
-        else
-            echo "Command failed"
-            let "failures++"
+        if [ $? -ne 0 ]; then
+            echo "CREATE EXTENSION command failed"
+            let "failure_count++"
+            failed_extensions+=("$line")
         fi
         printf "\n\n"
 done
-echo "FAILURES: $failures"
+echo "*** FAILURE COUNT ***: $failure_count"
+printf "\n*** FAILED EXTENSIONS ***:\n"
+for failed in "${failed_extensions[@]}"
+do
+      echo $failed
+done