Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add storybook #825

Open
1 task done
Tamir198 opened this issue May 28, 2024 · 7 comments · Fixed by #827
Open
1 task done

[FEATURE] Add storybook #825

Tamir198 opened this issue May 28, 2024 · 7 comments · Fixed by #827

Comments

@Tamir198
Copy link
Contributor

Detailed description

How about we will add storybook into the project

Context

This could help new contributors with easy landing when.

Possible implementation

No response

Additional information

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
Copy link

It's great having you contribute to this project

🌟 Welcome to the community 🌟

  • If you would like to continue contributing to open source and would like to do it with an awesome inclusive community.
  • You should join our Discord chat and our GitHub Organisation.
  • We help and encourage each other to contribute to open source little and often 😄.
  • Any questions let us know.

@Tamir198
Copy link
Contributor Author

I would love to work on this

@ArkadiK94
Copy link
Contributor

@Tamir198 Let's wait a response from @kabir0x23 first.

@ArkadiK94
Copy link
Contributor

@Tamir198 you can work on it. Thank you for creating this issue.
A link to the storybook please make sure that:

  • regular users don't need to have access to it.
  • in the website add it in admin dashboard. (@kabir0x23 could you make him team member in the website so he will see this dashboard?)
  • add the link also in the readme in this repo.

@ArkadiK94
Copy link
Contributor

  • we have a folder components/Common make all the components from there in storybook. Later we will think about adding more.

@kabir0x23
Copy link
Member

done: team

@ArkadiK94
Copy link
Contributor

ArkadiK94 commented Jun 1, 2024

  • add in contributing file about the usage of storybook
  • fix minor issues from last pr
  • '--docs' check to see why it is not working and fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants