Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic Enumerable and Collectable implementations #17

Open
turion opened this issue Jun 16, 2021 · 2 comments
Open

Generic Enumerable and Collectable implementations #17

turion opened this issue Jun 16, 2021 · 2 comments

Comments

@turion
Copy link
Contributor

turion commented Jun 16, 2021

The Enumerable and Collectable protocols can be implemented for Hallux.Internal.FingerTree, as far as I understand. For some operations (like count on Seq) there are more efficient specific functions in the special cases, but sometimes it would be nice to reuse generic functions when implementing a fingertree with a custom monoid.

@turion
Copy link
Contributor Author

turion commented Jun 16, 2021

I can try and submit a PR if you're interested.

@thalesmg
Copy link
Owner

Sure! I guess there'll be a need for special cases like IntervalMap's into and Seq's count as you have noted. But if you believe there can be some reuse for those and other use cases, then it sounds like a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants