Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation with quote inside sentence #5894

Open
toto975 opened this issue Oct 10, 2024 · 0 comments
Open

Translation with quote inside sentence #5894

toto975 opened this issue Oct 10, 2024 · 0 comments

Comments

@toto975
Copy link
Contributor

toto975 commented Oct 10, 2024

Laravel version

10.48

PHP version

8.3.11

Voyager version

1.7

Database

MariaDB 11.5.2

Description

the ' character is replaced by & # 039;

image

Steps to reproduce

In resources\views\media\manager.blade.php

...
                    if (!window.confirm('{{ __('voyager::media.crop_override_confirm') }}')) {
						return;
					}
...

In publishable\lang\fr\media.php

...
'crop_override_confirm'  => 'Cela remplacera l\'image originale, êtes-vous sûr ?'
...

Expected behavior

image

In resources\views\media\manager.blade.php, i change to
'{{ }}' ===> "{!! !!}"

...
                    if (!window.confirm("{!! __('voyager::media.crop_override_confirm') !!}")) {
						return;
					}
...

Maybe it must be everywhere in the javascript part.

Screenshots

No response

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant