Improve review labels for PRs

[apinnick]

I find the current PR labels "Not yet reviewed" confusing because it is assigned automatically and is not updated. This means that it is not easy to see which PRs actually need to be reviewed.

Can we ask reviewers to update the label to "review done"? "Review in progress" is also useful.

[ekohl]

It does get automatically updated, but I think few reviewers actually request changes and only submit a review

[Lennonka]

@ekohl Could it get updated also when someone just submits a review?

[ekohl]

I have thought about that before and think it makes sense. It's been on my todo list for ages to write up a description of how it works. Perhaps this is a good excuse to do so

[apinnick]

It does get automatically updated, but I think few reviewers actually request changes and only submit a review

@ekohl Are you saying it gets updated only if reviewers request changes? Not when a review is submitted?

That does not make sense. "LGTM" should count as a review.

[ekohl]

Example of where the bot is acting: theforeman/foreman#10245 (review)

It's important to know that there are 3 ways to submit a review:

• Approved
• Comment
• Request changes

Keeping that in mind when reading the code you should notice we only act on Approved and Request changes. I practice I often see use the second one: comment. We can easily start treating that the same as Request changes, but we don't do that today.

[apinnick]

Keeping that in mind when reading the code you should notice we only act on Approved and Request changes. I practice I often see use the second one: comment. We can easily start treating that the same as Request changes, but we don't do that today.

I also tend to use "Comment" in practice. I'm not sure why it would be desirable to treat "Comment" differently from "Approved" and "Request changes". Could we add this to the workflow?

[ekohl]

It was introduced in theforeman/prprocessor@dcc45c7. There's a very good chance that was right when the feature was introduced (I still recall using GH without the reviews feature and we just used inline comments) and things were less clear back then. I don't think it's been really discussed that much in the past (almost) 8 years.

[ekohl]

https://community.theforeman.org/t/reviewing-prprocessors-review-labels/38844