From e5435f10d66bca5e3f8bab0ba5e8d6e2da14e8d0 Mon Sep 17 00:00:00 2001
From: Davis Vaughan <davis@rstudio.com>
Date: Wed, 21 Aug 2024 16:46:31 -0400
Subject: [PATCH] Revert allowing data frames in `list_transpose()` (#1149)

* Revert allowing data frames in `list_transpose()`

* Tweak NEWS bullet

* One liner
---
 NEWS.md                                 |  3 ++-
 R/list-transpose.R                      |  3 +--
 tests/testthat/_snaps/list-transpose.md | 10 +++++++++-
 tests/testthat/test-list-transpose.R    |  7 ++++---
 4 files changed, 16 insertions(+), 7 deletions(-)

diff --git a/NEWS.md b/NEWS.md
index 5d5177af..815872cd 100644
--- a/NEWS.md
+++ b/NEWS.md
@@ -1,6 +1,7 @@
 # purrr (development version)
 
-* `list_transpose()` now works with data.frames (@KimLopezGuell, #1109).
+* Added a test to assert that `list_transpose()` does not work on data frames
+  (@KimLopezGuell, #1141, #1149).
 * Added `imap_vec()` (#1084)
 * `list_transpose()` inspects all elements to determine the correct
   template if it's not provided by the user  (#1128, @krlmlr).
diff --git a/R/list-transpose.R b/R/list-transpose.R
index a3dba5b2..e085558e 100644
--- a/R/list-transpose.R
+++ b/R/list-transpose.R
@@ -69,8 +69,7 @@ list_transpose <- function(x,
                            simplify = NA,
                            ptype = NULL,
                            default = NULL) {
-
-  check_list(x)
+  obj_check_list(x)
   check_dots_empty()
 
   if (length(x) == 0) {
diff --git a/tests/testthat/_snaps/list-transpose.md b/tests/testthat/_snaps/list-transpose.md
index 10ccbc6d..b7853277 100644
--- a/tests/testthat/_snaps/list-transpose.md
+++ b/tests/testthat/_snaps/list-transpose.md
@@ -1,3 +1,11 @@
+# can't transpose data frames
+
+    Code
+      list_transpose(df)
+    Condition
+      Error in `list_transpose()`:
+      ! `x` must be a list, not a <data.frame> object.
+
 # integer template requires exact length of list() simplify etc
 
     Code
@@ -57,7 +65,7 @@
       list_transpose(10)
     Condition
       Error in `list_transpose()`:
-      ! `x` must be a list, not a number.
+      ! `x` must be a list, not the number 10.
     Code
       list_transpose(list(1), template = mean)
     Condition
diff --git a/tests/testthat/test-list-transpose.R b/tests/testthat/test-list-transpose.R
index 872e5b7f..56ed28ba 100644
--- a/tests/testthat/test-list-transpose.R
+++ b/tests/testthat/test-list-transpose.R
@@ -4,10 +4,11 @@ test_that("can transpose homogenous list", {
   expect_equal(out, list(a = c(x = 1, y = 3), b = c(x = 2, y = 4)))
 })
 
-test_that("can transpose data frames", {
+test_that("can't transpose data frames", {
   df <- data.frame(x = 1:2, y = 4:5)
-  out <- list_transpose(df)
-  expect_equal(out, list(c(x = 1, y = 4), c(x = 2, y = 5)))
+
+  # i.e. be consistent with other `list_*()` functions from purrr/vctrs
+  expect_snapshot(error = TRUE, list_transpose(df))
 })
 
 test_that("transposing empty list returns empty list", {