Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HA issue about the PDClient #651

Open
iosmanthus opened this issue Sep 2, 2022 · 1 comment
Open

HA issue about the PDClient #651

iosmanthus opened this issue Sep 2, 2022 · 1 comment
Labels
type/bug Something isn't working

Comments

@iosmanthus
Copy link
Member

iosmanthus commented Sep 2, 2022

Bug Report

1. Describe the bug

While disabling the region cache and killing the PD leader, the client might be unavailable because of the wrong probe logic.

If the following code produces an exception like "retry is exhausted", the rest of the PD server will not be probed.

GetMembersResponse resp = getMembers(backOffer, url);

Another issue is, that the client becomes unavailable while the PD leader is down and encounters the TsoBatchUsedUp since the writer needs to acquire TS from TSO in TiKV 6.2.0. While handing TsoBatchUsedUp, the region cache should not be clean since the region is unavailable right not doesn't means it's not a leader.

2. Minimal reproduce step (Required)

  1. Create a 3-PD cluster and disable region cache every time after the request.
  2. Kill the PD leader.
  3. The client hangs.

3. What did you see instead (Required)

  1. The client will recover after the PD leader is elected.

5. What are your Java Client and TiKV versions? (Required)

  • Client Java: master
  • TiKV: v6.2.0
@iosmanthus iosmanthus added the type/bug Something isn't working label Sep 2, 2022
@iosmanthus iosmanthus changed the title Wrong retry logic in PDClient HA issue about the PDClient Sep 5, 2022
@github-actions
Copy link

github-actions bot commented Oct 6, 2022

This issue is stale because it has been open 30 days with no activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants