Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm_resource should allow an array of values for set #370

Open
chrisjohnson opened this issue Apr 1, 2022 · 5 comments
Open

helm_resource should allow an array of values for set #370

chrisjohnson opened this issue Apr 1, 2022 · 5 comments
Labels
enhancement New feature or request

Comments

@chrisjohnson
Copy link
Contributor

Many helm_remote and helm calls rely on arrays of set values. If helm_resource could accept that same array it would simplify interopability

@nicks
Copy link
Member

nicks commented Apr 1, 2022

From the README:

flags: Additional flags to pass to helm install (e.g., ['--set', 'key=value'])

is that what you're looking for?

@chrisjohnson
Copy link
Contributor Author

With helm_remote I can do set=helm_values where helm_values is

[
  'image.tag=%s' % foo,
  'environment.name=development',
  'foo.bar=baz'
]

I would similarly like to be able to pass set values as an array, as opposed to composing the --set a=b args myself. It would just make adoption much simpler since the "array of set strings" pattern is so widely used already

@nicks nicks added the enhancement New feature or request label Apr 1, 2022
@nicks
Copy link
Member

nicks commented Apr 1, 2022

i guess we'd accept a PR to translate helm_resource(set=...) to the appropriate flags.

i'm usually a bit skeptical of having two ways to do the same thing, but ya, this would make adoption from helm() easier.

@ManAnRuck
Copy link

helm_remote also allows a value.yaml file. Is this then also possible with helm_resource?

@nicks
Copy link
Member

nicks commented Jul 14, 2022

@ManAnRuck

helm_resource(..., flags=['--values=./path/to/values.yaml'])

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants