Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong id on pull request #202

Open
electrosenpai opened this issue Mar 17, 2017 · 0 comments
Open

wrong id on pull request #202

electrosenpai opened this issue Mar 17, 2017 · 0 comments

Comments

@electrosenpai
Copy link

electrosenpai commented Mar 17, 2017

Hi,

I'm searching throw the net for few day about this issue but I didn't find anything. Maybe I did something but ...

Gitlab version : 8.17.3 f0c970e
Jenkins version : Jenkins 2.32.3
Gitlab merge request plugin version : 2.0.0

The plugin merge request isn't working and after checking log I notice that the id of the pull request are wrong.

java.io.FileNotFoundException: https://mygitlaburl/api/v3/projects/42/merge_requests/7/notes
	at sun.net.www.protocol.http.HttpURLConnection.getInputStream0(HttpURLConnection.java:1872)
	at sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1474)
	at sun.net.www.protocol.https.HttpsURLConnectionImpl.getInputStream(HttpsURLConnectionImpl.java:254)
	at org.gitlab.api.http.GitlabHTTPRequestor.parse(GitlabHTTPRequestor.java:324)
	at org.gitlab.api.http.GitlabHTTPRequestor.to(GitlabHTTPRequestor.java:144)
	at org.gitlab.api.http.GitlabHTTPRequestor.to(GitlabHTTPRequestor.java:116)
	at org.gitlab.api.GitlabAPI.createNote(GitlabAPI.java:1073)
	at org.jenkinsci.plugins.gitlab.GitlabMergeRequestWrapper.createNote(GitlabMergeRequestWrapper.java:217)
	at org.jenkinsci.plugins.gitlab.GitlabMergeRequestWrapper.build(GitlabMergeRequestWrapper.java:258)
	at org.jenkinsci.plugins.gitlab.GitlabMergeRequestWrapper.check(GitlabMergeRequestWrapper.java:100)
	at org.jenkinsci.plugins.gitlab.GitlabRepository.check(GitlabRepository.java:86)
	at org.jenkinsci.plugins.gitlab.GitlabRepository.check(GitlabRepository.java:68)
	at org.jenkinsci.plugins.gitlab.GitlabMergeRequestBuilder.run(GitlabMergeRequestBuilder.java:28)
	at org.jenkinsci.plugins.gitlab.GitlabBuildTrigger.run(GitlabBuildTrigger.java:134)
	at hudson.triggers.Trigger.checkTriggers(Trigger.java:278)
	at hudson.triggers.Trigger$Cron.doRun(Trigger.java:226)
	at hudson.triggers.SafeTimerTask.run(SafeTimerTask.java:50)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
	at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
	at java.lang.Thread.run(Thread.java:745)

Mar 17, 2017 1:40:02 PM org.jenkinsci.plugins.gitlab.GitlabMergeRequestWrapper build
INFO: 
Mar 17, 2017 1:40:03 PM org.jenkinsci.plugins.gitlab.GitlabBuilds build
INFO: The target regex matches the target branch {master}. Source branch {toto}
Mar 17, 2017 1:40:03 PM org.jenkinsci.plugins.gitlab.GitlabBuilds build
INFO: Build is not supposed to run
Mar 17, 2017 1:40:03 PM org.jenkinsci.plugins.gitlab.GitlabMergeRequestWrapper createNote
SEVERE: Failed to create note for merge request 5
java.io.FileNotFoundException: https://mygitlaburl/api/v3/projects/42/merge_requests/5/notes
	at sun.net.www.protocol.http.HttpURLConnection.getInputStream0(HttpURLConnection.java:1872)
	at sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1474)
	at sun.net.www.protocol.https.HttpsURLConnectionImpl.getInputStream(HttpsURLConnectionImpl.java:254)
	at org.gitlab.api.http.GitlabHTTPRequestor.parse(GitlabHTTPRequestor.java:324)
	at org.gitlab.api.http.GitlabHTTPRequestor.to(GitlabHTTPRequestor.java:144)
	at org.gitlab.api.http.GitlabHTTPRequestor.to(GitlabHTTPRequestor.java:116)
	at org.gitlab.api.GitlabAPI.createNote(GitlabAPI.java:1073)
	at org.jenkinsci.plugins.gitlab.GitlabMergeRequestWrapper.createNote(GitlabMergeRequestWrapper.java:217)
	at org.jenkinsci.plugins.gitlab.GitlabMergeRequestWrapper.build(GitlabMergeRequestWrapper.java:258)
	at org.jenkinsci.plugins.gitlab.GitlabMergeRequestWrapper.check(GitlabMergeRequestWrapper.java:100)
	at org.jenkinsci.plugins.gitlab.GitlabRepository.check(GitlabRepository.java:86)
	at org.jenkinsci.plugins.gitlab.GitlabRepository.check(GitlabRepository.java:68)
	at org.jenkinsci.plugins.gitlab.GitlabMergeRequestBuilder.run(GitlabMergeRequestBuilder.java:28)
	at org.jenkinsci.plugins.gitlab.GitlabBuildTrigger.run(GitlabBuildTrigger.java:134)
	at hudson.triggers.Trigger.checkTriggers(Trigger.java:278)
	at hudson.triggers.Trigger$Cron.doRun(Trigger.java:226)
	at hudson.triggers.SafeTimerTask.run(SafeTimerTask.java:50)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
	at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
	at java.lang.Thread.run(Thread.java:745)

I have only 4 pull request on gitlab, so I just check the code and notice that the was 2 id :

this.mergeRequestId = mergeRequestId; this.mergeRequestIid = mergeRequestIid;

I will update this thread if I find something, but if anyone can help me would me nice :).

Thank you in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant