You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This probably(:tm:) isn't a bug in needle, but it appears in needle, so I thought I'd raise it here, just in case someone else is going insane.
Very, very occasionally, we get this error in tests:
TypeError: iconv.encodingExists is not a function
at StreamDecoder.Object.<anonymous>.StreamDecoder._transform (foo/node_modules/needle/lib/decoder.js:27:17)
at StreamDecoder.Transform._read (internal/streams/transform.js:205:10)
at StreamDecoder.Transform._write (internal/streams/transform.js:193:12)
at writeOrBuffer (internal/streams/writable.js:358:12)
at StreamDecoder.Writable.write (internal/streams/writable.js:303:10)
at IncomingMessage.ondata (internal/streams/readable.js:731:22)
at IncomingMessage.emit (events.js:412:35)
at IncomingMessage.emit (domain.js:475:12)
at IncomingMessage.Readable.read (internal/streams/readable.js:504:10)
at flow (internal/streams/readable.js:987:34)
at resume_ (internal/streams/readable.js:968:3)
at processTicksAndRejections (internal/process/task_queues.js:82:21)
I am reasonably sure this is impossible.
I have reviewed decoder.js and iconv-lite carefully. needle is loading a modern, compatible version of iconv-lite:
└─┬ needle@3.1.0
└── iconv-lite@0.6.3
We're using all kinds of mocking (jest 26, sinon 9, nock 13, etc.), but we have no reason to ever have touched iconv, or needle itself (beyond what nock does), and it's not isolated to any specific test. Node 14, linux.
I'll update here if we get anywhere.
The text was updated successfully, but these errors were encountered:
This probably(:tm:) isn't a bug in
needle
, but it appears inneedle
, so I thought I'd raise it here, just in case someone else is going insane.Very, very occasionally, we get this error in tests:
I am reasonably sure this is impossible.
I have reviewed
decoder.js
andiconv-lite
carefully.needle
is loading a modern, compatible version oficonv-lite
:We're using all kinds of mocking (jest 26, sinon 9, nock 13, etc.), but we have no reason to ever have touched
iconv
, orneedle
itself (beyond whatnock
does), and it's not isolated to any specific test. Node 14, linux.I'll update here if we get anywhere.
The text was updated successfully, but these errors were encountered: