Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirection problem with some sites #10

Open
yeyeto2788 opened this issue Sep 1, 2017 · 3 comments
Open

Redirection problem with some sites #10

yeyeto2788 opened this issue Sep 1, 2017 · 3 comments

Comments

@yeyeto2788
Copy link

yeyeto2788 commented Sep 1, 2017

Hey @tomhiggins.

After successfully installing Anyfesto there are some pages that are not redirected to the main page.

URL Redirect Error
http://www.google.com Yes None
http://www.raspberry.org Yes None
http://www.raspberry.org/blog/ No Cannot connect
http://www.instructables.com/category/technology/ No 404 - not found
https://www.thingiverse.com No Cannot connect

I guess this is an issue with the captive portal where the regex does not take into account https and the end of an URL.

I guess we might need to change this into something like \b.*(?<![0-9])

You can check if it works in here: (https://regex101.com/)[https://regex101.com/]

URLs that I use to test:

www.demo.com
http://foo.co.uk/
http://regexr.com/foo.html?q=bar
https://mediatemple.net/
http:10.99.11.1:19485
https://www.mediatemple.net/
google.com

Regards.

@yeyeto2788
Copy link
Author

Hey there!

Have you been able to reproduce the error?

Regards.

@tomhiggins
Copy link
Owner

I will try to get to it soon. Life has been keeping off the dev and debug, but I will try to get this on the ToDo stack Thanks for you patience.

@yeyeto2788
Copy link
Author

No problem, just trying to help :)

If you need any other information or anything I can do just let me know.
Best regards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants