Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid multiple Vertex definitions on .proto files #150

Open
d-roak opened this issue Sep 10, 2024 · 6 comments
Open

Avoid multiple Vertex definitions on .proto files #150

d-roak opened this issue Sep 10, 2024 · 6 comments
Labels
external contributors Open for external contributors feature New feature or request

Comments

@d-roak
Copy link
Member

d-roak commented Sep 10, 2024

We currently have double Vertex definitions on the network proto file and objects file. The network file is supposed to import the object one. Were having problems setting this because of the monorepo structure. buf is crying about something

@d-roak d-roak added feature New feature or request good first issue labels Sep 10, 2024
@d-roak
Copy link
Member Author

d-roak commented Sep 15, 2024

Assigned! If you have any questions, feel free to join our community channels:

https://t.me/topologyfrens
https://discord.gg/GUDGzBP5mn

@d-roak
Copy link
Member Author

d-roak commented Sep 25, 2024

more than 1 week of inactivity, i'm going to take the assignment

@supreme2580
Copy link

@d-roak Can I be assigned to this?

@d-roak
Copy link
Member Author

d-roak commented Oct 11, 2024

sure

@supreme2580
Copy link

@d-roak hey boss, turns out i'm travelling and won't be available to handle this, thank you for the opportunity🙏🏽

@supreme2580 supreme2580 removed their assignment Oct 13, 2024
@d-roak d-roak added external contributors Open for external contributors and removed good first issue labels Oct 14, 2024
@sfroment
Copy link
Contributor

sfroment commented Oct 19, 2024

Hey @d-roak ,
I have a solution for that but right now when you run proto-gen on main it will make a dir in packages/src/proto is that intended ?
You can see the way the import should be done here main...sfroment:ts-topology:dev/sfroment/fix-double-vertex but maybe we would like somthing else like topology/object ? In that case we would need to change other things let me knwo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external contributors Open for external contributors feature New feature or request
Projects
Status: 🗃️ Backlog
Development

No branches or pull requests

4 participants