Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code cleanup/improvements #8

Open
Morsey187 opened this issue May 9, 2024 · 1 comment
Open

Code cleanup/improvements #8

Morsey187 opened this issue May 9, 2024 · 1 comment

Comments

@Morsey187
Copy link

Morsey187 commented May 9, 2024

Some minor code improvements not yet implemented from a review of the initial commit:

  1. Delete media/.gitignore and use root .gitignore instead.
    Note: code was copied from bakerydemo, although approach is likely not necassary.

  2. Pass request object when calling .url on a page to avoid performance issues (see LinkStructValue class).

  3. Improve handling of placeholder image.
    get_placeholder_image shouldn't try and provide a fallback image or should at least point to a static file instead.

  4. Remove querystring_modify, perhaps with a tag from wagtailadmin_tags if possible.

  5. Update responsive images, Resolution switching is being used for srcset, although the same values are being used across different display resolutions (1x vs 2x).

@zerolab
Copy link
Member

zerolab commented May 9, 2024

re: querystring_modify, https://github.com/ababic/django-querystring-tag/ may be a better alternative

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants