New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSSQL database doesn't allow aliases in GROUP BY #813

Open

t3hn0 opened this issue Oct 17, 2023 · 1 comment

Contributor

t3hn0 commented Oct 17, 2023

This part of code is preventing SS5 to be run on MSSQL database.

Logical Query Processing in MSSQL is:

FROM
ON
JOIN
WHERE
GROUP BY
WITH CUBE/ROLLUP
HAVING
SELECT
DISTINCT
ORDER BY
TOP
OFFSET/FETCH

Since original SQL only returns prettier variable name it shouldn't do any harm.

Tested on SS5 with MSSQL and SS5 with MySQL.

Fixed in PR#812

t3hn0 mentioned this issue

MSSQL database doesn't allow aliases in GROUP BY #812

Merged

Collaborator

tractorcow commented Oct 19, 2023

Approved PR at #812. Can merge once build is passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment