Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flattop] Alternative light interception models (flat top, PPA) #417

Open
2 tasks
dfalster opened this issue May 27, 2024 · 0 comments
Open
2 tasks

[flattop] Alternative light interception models (flat top, PPA) #417

dfalster opened this issue May 27, 2024 · 0 comments
Assignees
Labels
epic A new feature or capability

Comments

@dfalster
Copy link
Member

dfalster commented May 27, 2024

Problem statement

Owner: @dfalster

As a user running simulations, I may want to run model with alternative light models, as these could offer different resolution and speed.

Elaboration: The ff16 model currently uses deep crown model. Lily Dun's hours explored alternatives, including a flat top and PPA (perfect plasticity Appoximation) in 3D simulations. Most other DGVMs use one of those.

A while back @aornugent programmed up a version of the PPA light model. (see branch https://github.com/traitecoevo/plant/tree/ff16-ppa). Currently it's implemented as a new strategy variant of ff16, but perhaps should be an option for FF16?

In the end, we may have:

  • deep crown
  • flat top
  • PPA
  • New model

Obviously, these aren't full implementations, as we're not utilising the simplification to speed up the calculations, either through analytic integration of density (best), or simplifying calculation of the light env. These could be added, but we'd need to extend the light environment to have different options.

Issues

Acceptance criteria

Given a simulation, we can

  • specify alternative light models
@dfalster dfalster changed the title Alternative light interception models (flat top, PPA) [pitch] Alternative light interception models (flat top, PPA) Jun 17, 2024
@dfalster dfalster added the epic A new feature or capability label Jun 17, 2024
@dfalster dfalster changed the title [pitch] Alternative light interception models (flat top, PPA) [flattop] Alternative light interception models (flat top, PPA) Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic A new feature or capability
Projects
Status: In Progress
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants