New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handling of hidden objects in `migrate` and `add_files`/`add_files_from_table` procedures #23891

Open

ebyhr opened this issue Oct 24, 2024 · 0 comments

Member

ebyhr commented Oct 24, 2024 •

edited

Loading

The first statement skips hidden objects correctly, but the 2nd statement doesn't.

ALTER TABLE region EXECUTE add_files('file:///tmp/add_files/.hidden', 'parquet');
ALTER TABLE region EXECUTE add_files('file:///tmp/add_files/.hidden/', 'parquet');

We should fix the logic around:

trino/plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/procedure/MigrationUtils.java

Lines 108 to 112 in f9f6943

    
           while (files.hasNext()) { 
        
               FileEntry file = files.next(); 
        
               String fileLocation = file.location().toString(); 
        
               String relativePath = fileLocation.substring(location.length()); 
        
               if (relativePath.contains("/_") || relativePath.contains("/.")) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment