Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement custom renderers property #13

Closed
dfguerrerom opened this issue Sep 28, 2024 · 2 comments
Closed

Implement custom renderers property #13

dfguerrerom opened this issue Sep 28, 2024 · 2 comments

Comments

@dfguerrerom
Copy link
Contributor

After reading the https://echarts.apache.org/en/api.html#echarts documentation, I found an option to change the renderer of the widget, either 'canvas' or 'svg', which can be very useful.
This feature doesn't seem too complicated to implement, just a couple of lines of code, however, the library now has two types of widgets, meaning that any new feature has to be added to the both of them, what do you think about adding a BaseWidgetView and a BaseWidgetModel? it would be easier to implement these methods... if you want I could draft a PR and/or follow your indications? if you see it as something feasible?

@trungleduc
Copy link
Owner

what do you think about adding a BaseWidgetView and a BaseWidgetModel? it would be easier to implement these methods...

I agree, this should be the way to go! And we should allow passing all options in the echarts.init call from the Python side. Your PRs are very welcome!

@trungleduc
Copy link
Owner

Fixed by #16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants