Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support musl libc? #98

Open
a-n-t-i-b-a-r-y-o-n opened this issue Nov 16, 2022 · 1 comment
Open

Support musl libc? #98

a-n-t-i-b-a-r-y-o-n opened this issue Nov 16, 2022 · 1 comment
Labels
enhancement New feature or request Linux Only on Linux OS

Comments

@a-n-t-i-b-a-r-y-o-n
Copy link

a-n-t-i-b-a-r-y-o-n commented Nov 16, 2022

Hi there! Love the project - been tinkering with it for hobby stuff and I'm very thankful that it exists.

Problem

Current Linux releases only support GNU libc

Suggested Change

Add support for musl libc

Background

In my (admittedly limited) testing, it appears this project builds and runs fine on Alpine Linux, which uses musl libc.
The existing Photino.Native Linux releases, however, result in segfault hell on musl libc systems.

Deconstructing the Photino.Native NuGet package indicates that the following runtimes are currently supported:

  • linux-arm64
  • linux-x64
  • osx-arm64
  • osx-x64
  • win-arm64
  • win-x64

These days, .NET makes the distinction in its runtime identifiers between "linux-x64" and "linux-musl-x64".

Open Question

Is the project open to supporting this runtime?
AFAIUI, this might incur additional costs in terms of Azure resources & build minutes.

I'll gladly open a PR to make the required makefile and pipeline changes if this is something the project is open to supporting.

Didn't see anything here with "musl" in it, so figured I'd ask around before spending time making this change.

@MikeYeager MikeYeager added enhancement New feature or request Linux Only on Linux OS labels Nov 17, 2022
@MikeYeager
Copy link
Collaborator

MikeYeager commented Nov 17, 2022

@g-r-a-v-i-t-y-w-a-v-e This hasn't been on our radar. Thanks for bringing this up. We'd be happy to have some help with this. We do all of our testing on Ubuntu. If you do a pull request, please target the debug branch, not master. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Linux Only on Linux OS
Projects
None yet
Development

No branches or pull requests

2 participants