-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: Doesn't work in Chrome simulator when choosing any iPhone #83
Comments
When you choose iPhone, you should use touch events, rather then scroll events. |
It should still work, at least https://bodyscrolllock.vercel.app/ does |
We'll think about it... |
Maybe we add an option, like |
tua-body-scroll-lock@1.6.0-beta.1 |
@BuptStEve Why another option ? I think overflowType should be respected everywhere unless it creates other problems ? I had some other issue with overflow: hidden and position: sticky but I sadly I couldn't reproduce from my limited memory, maybe they already got fixed since my message last year. |
Yeah, we need a reproduction demo to test functionality. |
I was testing the demo and it was working on desktop, but not on mobile.
I finally realized, that when using the "iPhone" preset in Chrome, it changes the user-agent and the scroll lock doesn't work (it doesn't add the style attribute to the body or html).
If I change for Nexus 5 (or any android device), the scroll lock works.
The text was updated successfully, but these errors were encountered: