Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are you interested on adding new features to this project #32

Open
santilin opened this issue Sep 16, 2023 · 4 comments
Open

Are you interested on adding new features to this project #32

santilin opened this issue Sep 16, 2023 · 4 comments

Comments

@santilin
Copy link

santilin commented Sep 16, 2023

Hi, I have added some features to your project, but maybe they are out of the scope of this project.
Would you be interested on reviewing them and then asses if I should go for a new project or upgrade yours?

@tuyakhov
Copy link
Owner

Hi @santilin. Thanks for your interest in this project. Yes, I am open to discussing any new features you think could be useful. Feel free to share them here.

@santilin
Copy link
Author

Hi, glad to hear from you.

I have forked your project to santilin/yii2-notifications. I have added handling error management.

Would you have a look at it and consider adding a PR?

@tuyakhov
Copy link
Owner

I'm not sure what "handling error management" really means. I am trying to keep this library as tiny as possible and agnostic of any additional error management system you might have in your project.

@santilin
Copy link
Author

I understand.
I am adding some functionality that is fairly generic, but of course, it extends your library.
Handling error management means that I store all errors produced in every channel inside the notificacion so that afer sending it I can see if there has been any error and get every error.

In case this funcionality is not added to your library, what I understand, it is not easy to add it without a rewriting of your code, so to make it a library, I suppose I should create a different lilbrary with a different namespace.

Do you agree?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants