Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idea: BloomFilterAggregator can directly rely on a BitSet instead of a BFMonoid #675

Open
anish749 opened this issue May 5, 2019 · 0 comments

Comments

@anish749
Copy link
Contributor

anish749 commented May 5, 2019

@johnynek I was going through your talk here from Scale by the Bay 2018 about immutable APIs and mutable internals.

I had a very rough idea about the BloomFilterAggregator and how it would look following the design pattern you discussed, I tried it in this gist here

Do you think this would work if we use a version of the cats BitSet which works great when a low number of bits are set?

@anish749 anish749 changed the title Idea: BloomFilterAggregator can keep internal state backed by private mutable structures. Idea: BloomFilterAggregator can directly rely on a BitSet instead of a BFMonoid May 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant