Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flakey test: downsiding HLL to 4 bits #742

Closed
johnynek opened this issue Nov 7, 2019 · 1 comment
Closed

flakey test: downsiding HLL to 4 bits #742

johnynek opened this issue Nov 7, 2019 · 1 comment

Comments

@johnynek
Copy link
Collaborator

johnynek commented Nov 7, 2019

[info] ! HyperLogLog.Downsize dense HLLs from 14 bits to 4 bits: Falsified after 0 passed tests.

[info] > Successes: 80 (out of 100)

[info] > Expected successes: 99.72

[info] > Required successes: 84.55

[info] > Example failures:

[info]   >: Exact result: 5000. Approx result: Approximate(566,2575,4585,0.9972).

[info]   >Exact result: 5000. Approx result: Approximate(566,2575,4585,0.9972).

[info]   >Exact result: 5000. Approx result: Approximate(566,2575,4585,0.9972).

[info]   >Exact result: 5000. Approx result: Approximate(566,2575,4585,0.9972).

[info]   >Exact result: 5000. Approx result: Approximate(566,2575,4585,0.9972).

I think what may be happening here is that 4 bits are too small for the std-dev to be a very accurate model, and as such the test is too strict.

@johnynek
Copy link
Collaborator Author

johnynek commented Nov 7, 2019

duplicate of #572

@johnynek johnynek closed this as completed Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant