From 47f6c77d43df94d544552d12c5981527ed470302 Mon Sep 17 00:00:00 2001 From: tympanix Date: Thu, 8 Mar 2018 14:39:29 +0100 Subject: [PATCH] Return HTTP 204 when no subtitles found --- api/api_subtitle.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/api/api_subtitle.go b/api/api_subtitle.go index 373f4f5..0ff9558 100644 --- a/api/api_subtitle.go +++ b/api/api_subtitle.go @@ -143,10 +143,13 @@ func (a *API) downloadSubtitles(w http.ResponseWriter, r *http.Request) interfac if err != nil { return Error(err, http.StatusBadRequest) } - _, err = a.DownloadSubtitles(media, langs, ioutil.Discard) + num, err := a.DownloadSubtitles(media, langs, ioutil.Discard) if err != nil { return Error(err, http.StatusBadRequest) } + if num <= 0 { + return Error(errors.New("no subtitles found"), http.StatusNoContent) + } files, err := a.fileList(folder) if err != nil { return Error(err, http.StatusBadRequest)