Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove HrsUrlHelper in favor of static methods in HrsUrl itself #6

Open
apetro opened this issue Dec 16, 2013 · 1 comment
Open

Remove HrsUrlHelper in favor of static methods in HrsUrl itself #6

apetro opened this issue Dec 16, 2013 · 1 comment
Assignees
@apetro
Labels
hrs-api
Milestone
1.0.0-GA

Comments

@apetro
Copy link
Contributor

apetro commented Dec 16, 2013

HrsUrl doesn't need a Helper if it can help itself.

Per @dima767 's feedback here:
apetro@2b77226#commitcomment-4863109

Eliminate HrsUrl instead adding a static method to the HrsUrl enum for parsing a String to a HrsUrl.

This should be completed before 1.0 GA so as to not ship an unnecessarily complicated API.
apetro referenced this issue in apetro/hrs-portlets Dec 16, 2013
@apetro
adds enums documenting role and url keys.
2b77226
@ghost ghost assigned apetro Dec 16, 2013
@apetro
Copy link
Contributor Author

apetro commented Dec 18, 2013

Pull Request #14 addresses this.

@apetro apetro mentioned this issue Dec 18, 2013
Merged
apetro added a commit to apetro/hrs-portlets that referenced this issue Sep 23, 2014
@apetro
Merge pull request uPortal-Attic#6 from UW-Madison-DoIT/benefit-confi…
2aae846 
…rmations-not-benefit-statements

HRSPLT-154 : Changed spec to reflect change to spec on cypress side
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@apetro apetro

Labels
hrs-api
Projects
None yet
Milestone
1.0.0-GA
Development

No branches or pull requests
1 participant
@apetro