Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation arrows cover content #7

Open
mivoligo opened this issue Nov 21, 2016 · 10 comments
Open

Navigation arrows cover content #7

mivoligo opened this issue Nov 21, 2016 · 10 comments

Comments

@mivoligo
Copy link

The left and right navigation arrows cover text on the pages. Screenshot with example attached.
screenshot at 15-26-45

@didrocks
Copy link
Member

This depends on your browser size, correct? and if you scroll down, then, you can copy the content and read it all, correct?

I'm unsure where we would put them if not in a fixed position?

@mivoligo
Copy link
Author

Yes, it does depend on the browser size. It's true that in the case visible on the screenshot, I can scroll down to see the text to copy. But generally the last line of text which is at the bottom of the page is covered by the navigation arrows even if I scroll down maximally.

Possible solutions:

  • make sure the page content is above the arrows when scrolled down (move the arrows down a bit)
  • make the navigation arrows semi-transparent

@didrocks
Copy link
Member

oh, do you have particular codelabs steps when that happens? I think we can add some general padding at the bottom if needed.

@mivoligo
Copy link
Author

In "Create your first snap" steps: 4,5,6,8
In "Basic snap usage" steps: 2,3,4,5

@mivoligo
Copy link
Author

Interestingly, in the narrow view (without the navigation on the left hand side), the padding is just fine. When I scroll down, the arrows are below the text.

@mivoligo
Copy link
Author

zrzut ekranu z 2016-11-30 10-09-24

@mivoligo
Copy link
Author

zrzut ekranu z 2016-11-30 10-09-40

@didrocks
Copy link
Member

Yes! Ok, I'll add a little bit of padding to fix it in the coming days. Thanks for your help and feedback! :)

@mivoligo
Copy link
Author

awesome! thanks for working on this!

@Apeshere
Copy link

image (screenshot page link:http://localhost:8123/codelabs/create-first-snap#5)
just to add an additional screenshot on the situation, scrolled all the way down, but still can't see one of the word in the last sentence. Same thing happens from step 3 to step 6, and step 8 in the create your first snap codelab.

here is my browser info:
Browser window width: 1535
Browser window height: 786
Screen width: 1600
Screen height: 900
Screen color depth: 24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants