Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Message in favour of Packet #56

Open
decanus opened this issue Sep 10, 2019 · 0 comments
Open

Remove Message in favour of Packet #56

decanus opened this issue Sep 10, 2019 · 0 comments
Labels
wontfix This will not be worked on
Milestone

Comments

@decanus
Copy link
Contributor

decanus commented Sep 10, 2019

Problem

We currently have 2 methods of representing a message that gets sent around within UB. One is the Message type and the other is the Packet protocol buffer. The main differences are the fact that the Message type is "more" type safe and has the last sender of a message.

Acceptance Criteria

We remove message from our codebase and pass around (last_sender, packet) as a tuple where necessary. Functions that are responsible for sending a message take the input parameters as UB specific types and later cast them to those required for the protobuf internally.

@decanus decanus added this to the v0.3.0 milestone Sep 10, 2019
@decanus decanus added the wontfix This will not be worked on label Oct 22, 2019
@decanus decanus mentioned this issue May 5, 2020
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant