Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[suggestion] use a good graphql library #526

Open
macrozone opened this issue Dec 2, 2022 · 0 comments
Open

[suggestion] use a good graphql library #526

macrozone opened this issue Dec 2, 2022 · 0 comments
Labels
feature request Suggest an idea for this project

Comments

@macrozone
Copy link
Contributor

This is not really a feature request, but I suggestion to avoid a wide category of bugs. But it would also wastly simplify extending graphql request.

at the moment, unchained still uses hand-written schemas and resolvers. This approach is not sound (type safe) and can lead to bugs like #525 or any other type-missmatch.

There are good "code-first" approaches to write graphql. Unfortunatly many of those are not created with 100% type-safety in mind. An exception is https://pothos-graphql.dev/

Pothos has a builder api and can actually guarantee type-safety on arguments and resolvers, including proper null/non-null checks (if strict mode is on, which is mandatory for any library/framework imho).

Additionaly, unchained could wrap and expose pothos api to projects using unchained which would wastly simplify extendig the graphql-api of unchained and enforce correctness.

@macrozone macrozone added the feature request Suggest an idea for this project label Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Suggest an idea for this project
Projects
None yet
Development

No branches or pull requests

1 participant