Skip to content
This repository has been archived by the owner on Oct 13, 2021. It is now read-only.

Consider not using elm-ui for code formatting. #34

Open
zenhack opened this issue Sep 7, 2019 · 8 comments
Open

Consider not using elm-ui for code formatting. #34

zenhack opened this issue Sep 7, 2019 · 8 comments

Comments

@zenhack
Copy link
Collaborator

zenhack commented Sep 7, 2019

The current elm-ui pretty printer does some weird things with layout, and it's a little hard to write pretty printers with it. It might be easier to just put strings together when formatting the code and just wrap the result in a <pre> tag. Talked to @ashishsc about this a bit. Thoughts?

@ashishsc
Copy link
Collaborator

ashishsc commented Sep 7, 2019

For just textual layout for sure, but if we start making the terms clickable and more fancy then I think elm-ui layout is fine

@mitchellwrosen
Copy link
Member

Totally agree! I was only using elm-ui to print terms because it was convenient. But it produces wonkly looking things, and should just be replaced, probably sooner rather than later.

@mitchellwrosen
Copy link
Member

(Assuming whatever we use instead will allow us to do fancy on-hover things etc)

@ashishsc
Copy link
Collaborator

ashishsc commented Sep 8, 2019 via email

@zenhack
Copy link
Collaborator Author

zenhack commented Sep 8, 2019 via email

@ashishsc
Copy link
Collaborator

ashishsc commented Sep 8, 2019

Ah yeah that's true.

@zenhack
Copy link
Collaborator Author

zenhack commented Sep 9, 2019

Heads up: I started working on this on a brance (pre-pp on my fork). Still very WIP.

@zenhack zenhack removed their assignment Nov 12, 2020
@zenhack
Copy link
Collaborator Author

zenhack commented Nov 12, 2020

Unassigned myself, as I'm not likely to work on this at this point.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants