Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase correction needs to work when # of pulses is smaller #88

Open
joefowler opened this issue Mar 24, 2017 · 4 comments
Open

Phase correction needs to work when # of pulses is smaller #88

joefowler opened this issue Mar 24, 2017 · 4 comments
Labels
bug Something isn't working minor

Comments

@joefowler
Copy link
Member

Original report by Joseph Fowler (Bitbucket: joe_fowler, ).


phase_correct(), the 2015 version, can give ridiculous "corrections" when the # of photons is small. This needs to be improved.

First, do no harm.

@joefowler
Copy link
Member Author

Original comment by Joseph Fowler (Bitbucket: joe_fowler, ).


Get this resolved for MASS v0.6

@joefowler
Copy link
Member Author

Original comment by Joseph Fowler (Bitbucket: joe_fowler, ).


Note that this never got resolved! I wrote on April 13 what I wanted to do, but I never did it.

@joefowler
Copy link
Member Author

Original comment by Joseph Fowler (Bitbucket: joe_fowler, ).


Actually, issue #93 was fixed in April. This is separate: how to work on data with too few pulses for phase correct to operate. I'm going to put this on hold and leave it out of mass 0.6, but we can reopen it later if we find the perfect data set for the work.

@joefowler
Copy link
Member Author

Original comment by Joseph Fowler (Bitbucket: joe_fowler, ).


Remove this from v0.6 milestone and wait until we have a good data set that we can test out ideas on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working minor
Projects
None yet
Development

No branches or pull requests

1 participant