-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code refactoring in Desmo
module
#12
Comments
I have to investigate the role of dealId before answering. I am puzzled as I was here. Having
I think we returned those IDs for easy accessing and referring to the transaction ID from the frontend.
It should be a sanity check that the DApp is not compromised but I need another pass of iExec documentation reading to be sure if it is really needed. |
I may have found a partial answer to why we select the first Unluckily, this doesn't explain why it's done in the first place, maybe is just a simplification which is OK for a demo but not for production (or maybe is OK for production also, I have no clue about this).
Then we'll leave it as it is. |
Why cannot we merge together
buyQuery
andgetQueryResult
into an atomic function calledexecuteQuery
?In this case, we wouldn't need to store the
dealid
into thethis.dealid
member...Here there's an example of why the current code can be a source of problems:
Desmo
module #12):Why cannot we simply return the
result
? Are the other values really useful for users of the SDK?verifyCallbackAddress
method? Do we really need it in theDesmo
module?The text was updated successfully, but these errors were encountered: