-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Epsilon on double and float #32
Comments
Help still needed? I can pick up this one :) |
@GKotfis sure! Feel free to take this one :) |
Before I change bunch of code I'd like to show my approach. |
I read the article and it looks good to me. Your implementation also looks good, however I think you should also consider handling |
Currently we don't support Epsilon in extensions for double and float. The suggestion is that each method should have default parameter like:
(this IValitRule<TObject, double> rule, double value, double epsilon = 0.0d)
so user can specify it, but it's not required. Each method should then consider this number in the calculations. Need to applied for:
The text was updated successfully, but these errors were encountered: