Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance #13

Open
plc-dev opened this issue Feb 18, 2020 · 1 comment
Open

Performance #13

plc-dev opened this issue Feb 18, 2020 · 1 comment

Comments

@plc-dev
Copy link

plc-dev commented Feb 18, 2020

Hey, I've noticed some big performance hits on usage with above ~50-60 items in an accordion, to the point of having the "item:ready"-Events stretch out for a span of over 5 seconds on above 100 items. The items are displayed only after all of the events have passed.
Also this amount of items in an accordion impacts the response time to the unfolding/folding animation of the clicked element.

I've also tried passing empty items in, but that didn't affect the construction time. On smaller sizes the accordion works smoothly, so I'm guessing it's not an issue on my end as I also pretty much sticked to the example usage.

Is this component just not designed for accordions this size or could there be anything done about the performance?

@vanderb
Copy link
Owner

vanderb commented Feb 25, 2020

Hi @plc-dev

thanks for reporting.

You said it caused in "item:ready"-event, so it may be a bug in this package.
But I have to take a look into this.

If it's a performance-issue of badger-accordion itself it should be reported on the badger-accordion-package-repository.

I'll get in here if I found any issues!

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants