Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experiment deployment in Lab descriptor file #219

Open
ravikiran2020 opened this issue Aug 24, 2023 · 1 comment
Open

Experiment deployment in Lab descriptor file #219

ravikiran2020 opened this issue Aug 24, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@ravikiran2020
Copy link
Contributor

Description:
Currently, there is an issue in the hosting process of experiments using the lab-descriptor.json file. The lab-descriptor.json file is intended to specify which experiments should be deployed by setting the "deploy" flag to either true or false. However, the deployment process is not adhering to this specification. Even when the "deploy" flag is set to false for certain experiments, they are still being hosted and deployed.

Steps to Reproduce:
Create a lab-descriptor.json file with multiple experiments defined, each with their respective properties including the "deploy" flag.
Set the "deploy" flag to false for one or more experiments that should not be hosted.
Initiate the hosting process using the appropriate command or tool, referencing the lab-descriptor.json file.
Observe that experiments with the "deploy" flag set to false are still being deployed and hosted alongside those set to true.

Expected Behavior:
Experiments with the "deploy" flag set to true should be hosted and deployed, while experiments with the "deploy" flag set to false should not be deployed and should remain inactive.

Actual Behavior:
Experiments with the "deploy" flag set to false are also being deployed and hosted, contrary to the specification in the lab-descriptor.json file.

Proposed Solution:
Investigate and identify the root cause of the issue in the deployment process. Ensure that the deployment process accurately reads and respects the "deploy" flag specified in the lab-descriptor.json file. Implement necessary changes to the deployment logic so that experiments with "deploy" set to false are excluded from the hosting process.

@ravikiran2020 ravikiran2020 added the bug Something isn't working label Aug 24, 2023
@Vanshika-Dhingra
Copy link
Collaborator

in langen.js
in moveToDeployDir function on line 67 before deploying an experiment see if e.deploy==True only then perform the movement process otherwise not

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants