Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Spark Lines to Handle Data Gaps #118

Open
vkoves opened this issue Aug 31, 2024 · 0 comments
Open

Improve Spark Lines to Handle Data Gaps #118

vkoves opened this issue Aug 31, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@vkoves
Copy link
Owner

vkoves commented Aug 31, 2024

The spark lines added in PR #116 works great 95% of the time, but with buildings with data gaps, like Willis tower, it doesn't perform draw a line, and only shows the min and max points, and then dots on hover.

Screenshot from 2024-08-30 19-18-40

We should also consider some way of adding tests for this component, whether Vitetest unit tests, a page with some randomly generated data, or both.

@vkoves vkoves added the bug Something isn't working label Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant