-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow vrdev.buildTools.defaultVersion to be overridden by .vscode/settings.json #154
Comments
Hi @Indy-rbo , could you double check if this is not somehow related to another configuration of VS Code? |
Hi @VenelinBakalov ! Sorry this isn't an issue with setting it in my personal Using the setting in that file will show the behavior in my screenshot :) |
Oh, got it, I understand now, thanks for the clarification |
From what I see there should be an option to change the scope to "window" which relates to the UI tab -> Workspace settings. But I am not sure if this will do the job for your case. |
This is what I am referring to: |
I'm not sure if the last part about not affecting other instances is a big downside? Looking at https://code.visualstudio.com/api/references/contribution-points#Configuration-property-schema (and scrolling down to the scope header) also shows the scope Or even I'm not well versed in VSCode extensions, but I've seen other extensions use this scope which worked for us. I can't recommend what scope would be the best, as long as I could override it in the workspace 😅 |
I tried the different settings suggested, machine-overridable and resource truly seem the most flexible - you have both user and workspace settings plus the option for local file that takes highest precedence. Once you start removing those options one by one, the next in line takes precedence (removing the local file, leaving the UI setting empty, removing the setting from the users settings.json and so on). |
Yes I agree that |
Hi @VenelinBakalov thanks again for fixing this so quickly! |
Hi @Indy-rbo , since you need this feature we should be able to release this week. I will keep you posted. |
Everything went fine, 2.5.5 is now available in the marketplace: https://marketplace.visualstudio.com/manage/publishers/vmware-pscoe |
Happy to help. Thanks for the quick release as well! |
Description
In #10 the setting
vrdev.buildTools.defaultVersion
was added with the scope ofapplication
.vrealize-developer-tools/package.json
Line 507 in fb54b05
I would like this scope to be set to something which allows it to be overridden in
.vscode/settings.json
(likeworkspace
?). So that all team members have it set to the same version.It currently shows the following message when I want to override it:
The text was updated successfully, but these errors were encountered: