Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spikes on S0 line #503

Open
majowi5 opened this issue Nov 8, 2021 · 6 comments
Open

Spikes on S0 line #503

majowi5 opened this issue Nov 8, 2021 · 6 comments

Comments

@majowi5
Copy link

majowi5 commented Nov 8, 2021

I have a lot of spikes on an S0 line. It is difficult to get rid of them. They would be easily detectable, as they are much shorter than a regular signal.
Vzlogger offers a debounce_delay but no option to define a minimum signal high time, to recognize a regular signal and
to dissmiss spikes easily.

I think this would be a very useful enhancement. Is there a chance to get this implemented?

@Tomcat42
Copy link

Tomcat42 commented Nov 8, 2021 via email

@majowi5
Copy link
Author

majowi5 commented Nov 9, 2021

@Tomcat42 : sorry, but this does not answer my question
I know your recomendation, but sometimes it is the other way round.
Have a nice evening.

@mbehr1
Copy link
Contributor

mbehr1 commented Nov 9, 2021 via email

@majowi5
Copy link
Author

majowi5 commented Nov 10, 2021

signal must be at least for the minimum time defined high (or low) to change the state in vzlogger.
Example:
signal is active high, if the signal is high for a time shorter than the minimum time defined, the high signal is ignored. Same is valid for low; if the signal is low for a period shorter than the minimum time defined, the low signal is ignored.
Time range should be about 10 ms to 2000ms (I suppose I will need a value at about 200ms)

My frequency is far less than 1 Hz, about 1 signal per minute.

@brlnr23
Copy link

brlnr23 commented Feb 20, 2022

I had to deal recently with the same issue. A few signals were simply wrong, cause by interferences with whatsoever. My technical skills to fix the hardware are limited that much, that I tried to understand what exactly is going wrong by logging the signals with a small Python script. It turned out, that the issue @majowi5 described was exactly what I was suffering from. Signals < 10ms while regular signals are >100ms.

In general I would agree that "fixing the root cause" is way more preferred than putting a strip on it somewhere else, but in my case that would be simply inefficient.
In the end I fixed my issue by using a custom Python script instead of vzlogger which posts data to the middleware via curl.

A configuration option for the min and the max length of a "valid" signal would help me a lot.

@wrichter
Copy link

This is implemented in #525

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants