Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests failing after updating to v1.3.0 #27

Open
adambiggs opened this issue Mar 8, 2017 · 2 comments
Open

Unit tests failing after updating to v1.3.0 #27

adambiggs opened this issue Mar 8, 2017 · 2 comments

Comments

@adambiggs
Copy link
Contributor

adambiggs commented Mar 8, 2017

I still need to investigate the cause, but after updating to v1.3.0 my unit tests are now failing:

PhantomJS 2.1.1 (Mac OS X 0.0.0) ERROR
  SyntaxError: Unexpected token ')'
  at webpack:///~/vue-bulma-datepicker/src/BaseInput.js:6:0 <- index.js:32158

My project was set up using Vue Webpack template.

@adambiggs
Copy link
Contributor Author

adambiggs commented Mar 8, 2017

I was able to fix this by telling Webpack to run vue-bulma-datepicker through babel-loader.

      {
        test: /\.js$/,
        loader: 'babel-loader',
        include: [
          resolve('src'),
          resolve('test'),
          resolve('node_modules/vue-click-outside'),
          resolve('node_modules/vue-bulma-datepicker') // Adding this fixed the errors
        ]
      }

To make this library easier to use, it might be nice to add a dist/ directory with pre-compiled files that can be used without any extra steps.

@luventa
Copy link
Member

luventa commented Mar 9, 2017

Yes, will do. Unpackaged vue file is not convenient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants