Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we extend the SuccessResponse Object? #407

Open
Zhaph opened this issue Nov 3, 2021 · 0 comments
Open

Should we extend the SuccessResponse Object? #407

Zhaph opened this issue Nov 3, 2021 · 0 comments

Comments

@Zhaph
Copy link

Zhaph commented Nov 3, 2021

Since API v46, the response for the Upsert Request has changed in two significant ways

  1. The created parameter has been added to the successful response object.
  2. Updates now return a 200 OK with a full body response instead of an empty response.

Previously I'd been using the existence of an Id in the response to indicate that the Upsert had created an object, and the lack of one to indicate an update to an existing object - this is no longer true.

At the moment, my code doesn't do much apart from logging the difference, but this might be more of an impact for others.

  • Does anyone else see the need to expose the Created property?
  • Should this just be added to the standard SuccessResponse object, or should we look to modify the calls used by upsert from the general Patch requests to UpsertPatch requests that return an UpsertSuccessResponse?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant