Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differentiation of googlemail and gmail accounts #253

Open
dreaquil opened this issue Oct 14, 2024 · 0 comments
Open

Differentiation of googlemail and gmail accounts #253

dreaquil opened this issue Oct 14, 2024 · 0 comments

Comments

@dreaquil
Copy link

Describe the bug
After integrating drf-social-oauth2, a user was able to sign up with their Google account using both @googlemail.com and @gmail.com email addresses. This resulted in two separate user accounts being created in the Django database for what should be a single user.

To Reproduce
Steps to reproduce the behavior:

  1. Go to the application's sign-up page
  2. Click on 'Sign up with Google'
  3. Sign in with a Google account using the @googlemail.com domain
  4. Log out and repeat steps 1-2
  5. Sign in with the same Google account using the @gmail.com domain
  6. Check the Django admin panel or user database

Expected behavior
The system should recognize @googlemail.com and @gmail.com as equivalent domains for Google accounts and create only one user account in the Django database, regardless of which domain is used during sign-up.

Desktop (please complete the following information):

  • OS: [Not specified, please fill in if relevant]
  • Browser: [Not specified, please fill in if relevant]
  • Version: [Not specified, please fill in if relevant]

Smartphone (please complete the following information):

  • Device: [Not applicable for this issue]
  • OS: [Not applicable for this issue]
  • Browser: [Not applicable for this issue]
  • Version: [Not applicable for this issue]

Additional context
This issue is related to the handling of Google account email domains during the OAuth2 authentication process. It appears that the current implementation is not accounting for the fact that @googlemail.com and @gmail.com are treated as equivalent by Google but are being seen as distinct by our application. This could lead to problems with user account management and potential security issues if not addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant