From 7556be352aac39d151a53ad593a64dd167af629a Mon Sep 17 00:00:00 2001 From: Rene Nyffenegger Date: Fri, 2 Feb 2024 15:26:54 +0100 Subject: [PATCH] DIVE_VERSION does not need to be exported (#492) The value of the variable DIVE_VERSION is not needed in a spawned subprocess. Thus, the variable does not necessarily need to be exported. Arguably, the environment is less polluted if it is not exported. --- README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 19362a9f..e245925b 100644 --- a/README.md +++ b/README.md @@ -97,7 +97,7 @@ With valid `source` options as such: Using debs: ```bash -export DIVE_VERSION=$(curl -sL "https://api.github.com/repos/wagoodman/dive/releases/latest" | grep '"tag_name":' | sed -E 's/.*"v([^"]+)".*/\1/') +DIVE_VERSION=$(curl -sL "https://api.github.com/repos/wagoodman/dive/releases/latest" | grep '"tag_name":' | sed -E 's/.*"v([^"]+)".*/\1/') curl -OL https://github.com/wagoodman/dive/releases/download/v${DIVE_VERSION}/dive_${DIVE_VERSION}_linux_amd64.deb sudo apt install ./dive_${DIVE_VERSION}_linux_amd64.deb ``` @@ -112,7 +112,7 @@ sudo snap connect dive:docker-daemon docker:docker-daemon **RHEL/Centos** ```bash -export DIVE_VERSION=$(curl -sL "https://api.github.com/repos/wagoodman/dive/releases/latest" | grep '"tag_name":' | sed -E 's/.*"v([^"]+)".*/\1/') +DIVE_VERSION=$(curl -sL "https://api.github.com/repos/wagoodman/dive/releases/latest" | grep '"tag_name":' | sed -E 's/.*"v([^"]+)".*/\1/') curl -OL https://github.com/wagoodman/dive/releases/download/v${DIVE_VERSION}/dive_${DIVE_VERSION}_linux_amd64.rpm rpm -i dive_${DIVE_VERSION}_linux_amd64.rpm ```