Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

possible typos in one of your zsim articles #1

Open
Z-Y00 opened this issue Jul 13, 2020 · 4 comments
Open

possible typos in one of your zsim articles #1

Z-Y00 opened this issue Jul 13, 2020 · 4 comments

Comments

@Z-Y00
Copy link

Z-Y00 commented Jul 13, 2020

Hi ziqi,
Thanks a lot for your great blog, it helps me a lot.
I found one possible typo in your blog here.

When a parent event finishes execution, child events will be notified after an extra preDelay cycles after the parent completion cycle. When all parents of a child event is completed, the child event will be enqueued after an extra postDelay cycle delay.

Then you wrote

The children nodes are notified at cycle doneCycle + postDelay, as discussed above. 

Thanks~!

@Z-Y00
Copy link
Author

Z-Y00 commented Jul 13, 2020

Also, the

 recursively incoke the parentDone() function 

maybe a typo

@Z-Y00
Copy link
Author

Z-Y00 commented Jul 13, 2020

overly complicated doe to optimization

should be due?

@Z-Y00
Copy link
Author

Z-Y00 commented Jul 14, 2020

also

we use the zll clock ather than the logical core clock

might be rather?

@Z-Y00
Copy link
Author

Z-Y00 commented Jul 17, 2020

Also, for

The slab allocator is implemented in file phase_slab_alloc.h.

Which file are you referring to?
I only found this one https://github.com/s5z/zsim/blob/master/src/slab_alloc.h

Are you using an inside version of zsim ? I'm just a little bit curious.

@Z-Y00 Z-Y00 changed the title A possible typo in one of your zsim articles possible typos in one of your zsim articles Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant