Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClientId may be undefined when using FedCM login #76

Closed
infinnie opened this issue May 31, 2024 · 2 comments
Closed

ClientId may be undefined when using FedCM login #76

infinnie opened this issue May 31, 2024 · 2 comments

Comments

@infinnie
Copy link

Describe the bug
When using FedCM sign-in in Google Chrome, the clientId field passed to the callback may be undefined.

To Reproduce
Steps to reproduce the behaviour:

  1. Log in to Google Chrome
  2. Open a page that calls useOneTap() method to display Google’s OneTap sign in UI.
  3. When clicking Continue as [[your name]], onSuccess() is not called, and onError() is called without arguments.

Reproducible Example
If you can please provide a reproducible example with Stackbliz, CodeSandbox or any other suitable service

Expected behaviour
A clear and concise description of what you expected to happen.

Screenshots

image

Desktop (please complete the following information):

  • OS: [e.g. iOS] Windows 11
  • Browser [e.g. chrome, safari] Chrome
  • Version [e.g. 22] 125.0.6422.142

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

@kasvith
Copy link
Collaborator

kasvith commented Jun 2, 2024

Hi, i still didnt have time to check with FedCM

@kasvith
Copy link
Collaborator

kasvith commented Jul 10, 2024

related #74

@kasvith kasvith closed this as completed Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants