Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support adaptions from MockAsset to other types than Resource #40

Open
henrykuijpers opened this issue May 31, 2024 · 1 comment
Open

Support adaptions from MockAsset to other types than Resource #40

henrykuijpers opened this issue May 31, 2024 · 1 comment

Comments

@henrykuijpers
Copy link
Contributor

MockAsset extends ResourceWrapper and implements Asset.

The adaptTo-method is overwritten with a simple check to return the correct resource, but adapting to other types goes to ResourceWrapper#adaptTo, which uses the wrapped Resource to do the adaption. In the end, this means that the wrapped Resource will always end up in the AdapterFactory, and not the Asset itself.
@stefanseifert
Copy link
Member

i'm not sure if i fully understand what's missing - can you come up with a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stefanseifert @henrykuijpers