Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tries to commit when when no changes and fails #469

Closed
FredCoen opened this issue May 16, 2022 · 4 comments
Closed

tries to commit when when no changes and fails #469

FredCoen opened this issue May 16, 2022 · 4 comments
Labels
duplicate This issue or pull request already exists

Comments

@FredCoen
Copy link

added this action to our CI however it fails as it tries to commit no changes.

error output:

"Your branch is up to date with 'origin/Implement-first-full-deposit-flow-on-short-term-bond-issuance-product-#7'.\n" +
'\n' +
'nothing to commit, working tree clean\n'

This a known issue? thanks

@FredCoen
Copy link
Author

FredCoen commented May 16, 2022

worklflow:


name: Lint

on: [push]
jobs:
  run-linters:
    name: Run linters
    runs-on: ubuntu-latest

    steps:
      - name: Check out Git repository
        uses: actions/checkout@v3

      - name: Set up node
        uses: actions/setup-node@v3
        with:
          node-version: 16

      - name: Install dependencies
        run: npm install

      - name: Run linters
        uses: wearerequired/lint-action@v2
        with:
          github_token: ${{ secrets.github_token }}
          prettier: true
          auto_fix: true
          eslint_args: '--max-warnings 0'
          prettier_extensions: 'sol'

@ocean90
Copy link
Member

ocean90 commented May 18, 2022

Can you check issue #140 if some of the mentioned workarounds are working for you too?

@FredCoen
Copy link
Author

yes the workaround worked. seems lock files changes by linter are preceived as changes but not by git

@ocean90 ocean90 added the duplicate This issue or pull request already exists label May 23, 2022
@ocean90
Copy link
Member

ocean90 commented May 23, 2022

Thanks, marking as a duplicate of #140.

@ocean90 ocean90 closed this as not planned Won't fix, can't repro, duplicate, stale May 23, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants