Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when performing the Wilcoxon test on the peak counts #312

Open
zhangyz1997 opened this issue May 20, 2024 · 1 comment
Open

Error when performing the Wilcoxon test on the peak counts #312

zhangyz1997 opened this issue May 20, 2024 · 1 comment

Comments

@zhangyz1997
Copy link

Hello everyone. Thank you for the excellent tool that integrates multiple modalities.
I am attempting to identify marker peaks across various clusters by following the section "Inferring linkage between ATAC and RNA data" in the vignette and executing the corresponding code.
runWilcoxon(int.bmmc, useDatasets = "atac", usePeak = TRUE)
It threw out error "unused arguments (useDatasets = "atac", usePeak = TRUE)". When I tried using runMarkerDEG instead
runMarkerDEG(int.bmmc, useDatasets = "atac", usePeak = TRUE)
It threw out error:
Error in match.arg(slot) : 'arg' should be one of “rawData”, “normData”, “scaleData”, “scaleUnsharedData”, “H”, “V”, “U”, “A”, “B”, “W”, “H.norm” Calls: runMarkerDEG -> .runDEG -> getMatrix -> getMatrix -> match.arg
So how could we complete the marker identification step?

@mvfki
Copy link
Collaborator

mvfki commented May 20, 2024

Hi Yuanzhe,

It looks like a bug from a rare case that we failed to pay attention to in our tests. Thanks for pointing it out and we will get it fixed ASAP.

Currently, I can share you some work around for this issue:

# You can include as many other datasets to use here
peakDatasets <- c("atac") 
# Extract `ligerDataset` class objects requested
datasetObjList <- datasets(int.bmmc)[peakDatasets]
# Extract the peak matrices
# Make sure these datasets are of "atac" modality so it has the slots, otherwise it'll show you an error
rawPeakList <- lapply(datasetObjList, slot, "rawPeak")
peakLiger <- createLiger(rawPeakList)
peakLiger <- normalize(peakLiger)

# Transfer the cluster labels from the original object to the new temporary object for marker calling
peakLiger$cluster <- cellMeta(int.bmmc, "leiden_cluster", useDatasets = "atac")
defaultCluster(peakLiger) <- "cluster"

# It should work this time to run marker detection now
markerTable <-  runMarkerDEG(peakLiger)

Hope this works for you! Please feel free to reach out if there's still any issues.

Best,
Yichen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants