Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Non-TLS) server should use System.TimeManager.withManager instead of initManager #190

Closed
edsko opened this issue Jul 17, 2024 · 1 comment · Fixed by #196
Closed

(Non-TLS) server should use System.TimeManager.withManager instead of initManager #190

edsko opened this issue Jul 17, 2024 · 1 comment · Fixed by #196
Labels
bug Something isn't working priority: medium Should be done before the library can be considered complete

Comments

@edsko
Copy link
Collaborator

edsko commented Jul 17, 2024

We currently use initManager, which means that we might leak some resources if the server is shut down. However, when we use withManager instead, the test suite fails:

    Test.Sanity.Interop
      cancellation
        client: FAIL
          Exception: KilledByHttp2ThreadManager (Just (BadThingHappen Network.Socket.sendBuf: resource vanished (Broken pipe)))

Currently unclear why.
@edsko edsko added bug Something isn't working priority: medium Should be done before the library can be considered complete labels Jul 17, 2024
@edsko edsko mentioned this issue Jul 17, 2024
Merged
@edsko
Copy link
Collaborator Author

edsko commented Jul 17, 2024

Possibly related: #156.

edsko added a commit that referenced this issue Jul 19, 2024
@edsko
With withManager
e16d2a1 
This depends on kazu-yamamoto/http2#137.
Closes #190.
@edsko edsko mentioned this issue Jul 19, 2024
Merged
edsko added a commit that referenced this issue Jul 24, 2024
@edsko
With withManager
12a267f 
This depends on kazu-yamamoto/http2#137.
Closes #190.
edsko added a commit that referenced this issue Jul 24, 2024
@edsko
With withManager
4c53f55 
This depends on kazu-yamamoto/http2#137.
Closes #190.
edsko added a commit that referenced this issue Jul 25, 2024
@edsko
With withManager
dc7d99e 
This depends on kazu-yamamoto/http2#137.
Closes #190.
@edsko edsko closed this as completed in 04d2ba2 Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working priority: medium Should be done before the library can be considered complete
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use withManager well-typed/grapesy
1 participant
@edsko